Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Structs mapper to gax #2284

Closed
kolea2 opened this issue Dec 4, 2023 · 2 comments
Closed

Add Structs mapper to gax #2284

kolea2 opened this issue Dec 4, 2023 · 2 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@kolea2
Copy link
Contributor

kolea2 commented Dec 4, 2023

Implementation in #2278, we are currently adding to java-core but would want to move to gax in a utility package at some point in the future. CC @blakeli0
@blakeli0
Copy link
Collaborator

blakeli0 commented Dec 5, 2023

In addition, we might want to file a request to protobuf, as I can see this being a generic util class provided to all protobuf users. For example, I do see a Structs class from protobuf which tries to easily construct a Struct type from field values, we may want to enhance it to convert from Struct to a Map.

@blakeli0 blakeli0 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Dec 5, 2023
@blakeli0
Copy link
Collaborator

blakeli0 commented Jan 2, 2024

Fixed by #2278

@blakeli0 blakeli0 closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blakeli0 @kolea2