feat: add parsing of autopopulated fields from serviceyaml #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeWang1127
reviewed
Dec 18, 2023
gapic-generator-java/src/main/java/com/google/api/generator/gapic/protoparser/Parser.java
Outdated
Show resolved
Hide resolved
gapic-generator-java/src/main/java/com/google/api/generator/gapic/protoparser/Parser.java
Outdated
Show resolved
Hide resolved
...tor-java/src/test/java/com/google/api/generator/gapic/protoparser/ServiceYamlParserTest.java
Outdated
Show resolved
Hide resolved
blakeli0
reviewed
Dec 19, 2023
gapic-generator-java/src/main/java/com/google/api/generator/gapic/protoparser/Parser.java
Outdated
Show resolved
Hide resolved
gapic-generator-java/src/main/java/com/google/api/generator/gapic/protoparser/Parser.java
Outdated
Show resolved
Hide resolved
gapic-generator-java/src/main/java/com/google/api/generator/gapic/protoparser/Parser.java
Outdated
Show resolved
Hide resolved
gapic-generator-java/src/main/java/com/google/api/generator/gapic/model/Method.java
Show resolved
Hide resolved
gapic-generator-java/src/main/java/com/google/api/generator/gapic/protoparser/Parser.java
Outdated
Show resolved
Hide resolved
gapic-generator-java/src/main/java/com/google/api/generator/gapic/model/Method.java
Show resolved
Hide resolved
product-auto-label
bot
added
size: l
blakeli0
reviewed
Dec 19, 2023
gapic-generator-java/src/main/java/com/google/api/generator/gapic/model/Field.java
Outdated
Show resolved
Hide resolved
gapic-generator-java/src/main/java/com/google/api/generator/gapic/model/Field.java
Show resolved
Hide resolved
blakeli0
reviewed
Dec 27, 2023
gapic-generator-java/src/main/java/com/google/api/generator/gapic/model/Field.java
Outdated
Show resolved
Hide resolved
gapic-generator-java/src/main/java/com/google/api/generator/gapic/model/Method.java
Outdated
Show resolved
Hide resolved
gapic-generator-java/src/main/java/com/google/api/generator/gapic/protoparser/Parser.java
Show resolved
Hide resolved
gapic-generator-java/src/main/java/com/google/api/generator/gapic/protoparser/Parser.java
Outdated
Show resolved
Hide resolved
blakeli0
approved these changes
Dec 28, 2023
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See b/309351289 for more details.
This PR adds parsing of the service_config.yaml file for autopopulated fields and adds them to the
FieldandMethodclasses.Follow-up: Add logic to
AbstractTransportServiceStubClassComposer.javato auto-populate the field (similar to how dynamic routing headers is added). We may go with a different design in the end, but that should be one viable approach.Note that I updated
echo.protofor testing; once this feature is implemented in gapic-showcase, I can look to remove those manual updates.