Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new artifact for sdk-platform-java configs. #2315

Merged
merged 4 commits into from Jan 3, 2024

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Dec 27, 2023

This artifact is meant to mirror java-shared-config with the java-shared-dependencies version to then be consumed by downstream libraries (including the monorepo and handwritten libraries). The purpose of this artifact is to have a single update PR in the downstream libs to update shared-config and shared-dependencies instead of two.

Name of the artifact: sdk-platform-java-config

@mpeddada1 mpeddada1 requested a review from a team as a code owner December 27, 2023 21:24
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Dec 27, 2023
Copy link
Contributor

@burkedavison burkedavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's get Tomo's approval as well since this is creating a new artifact.

@mpeddada1 mpeddada1 changed the title feat: new artifact to for sdk-platform-java configs. feat: new artifact for sdk-platform-java configs. Dec 28, 2023
@mpeddada1
Copy link
Contributor Author

@suztomo Could we get your final sign off on this PR?

@suztomo
Copy link
Member

suztomo commented Jan 3, 2024

10 mins after merging this, ensure the Release Please pull request #2290 updates appropriate lines.

@mpeddada1
Copy link
Contributor Author

Will do! Thanks

Copy link

sonarcloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mpeddada1 mpeddada1 merged commit 99e5195 into main Jan 3, 2024
38 checks passed
@mpeddada1 mpeddada1 deleted the new-shared-artifact branch January 3, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants