feat: Add Universe Domain to ClientSettings #2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakeli0
reviewed
Jan 2, 2024
| @@ -241,6 +246,12 @@ public B setClock(ApiClock clock) { | |||
| return self(); | |||
| } | |||
|
|
|||
| /** Sets the Universe Domain to configure the resolved endpoint */ | |||
| public B setUniverseDomain(String universeDomain) { | |||
There was a problem hiding this comment.
This is probably where showcase tests can help us find issues earlier. Can you please add a few showcase tests to verify that universe domain set through ClientSettings and StubSettings can be used for resolving endpoints?
There was a problem hiding this comment.
We've decided to park this. I'll create an issue to investigate aligning the stubsettings and clientsettings.
blakeli0
reviewed
Jan 2, 2024
gax-java/gax/src/main/java/com/google/api/gax/rpc/StubSettings.java
Outdated
Show resolved
Hide resolved
gcf-owl-bot
bot
removed
the
owlbot:run
|
|
blakeli0
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.