Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-enable checkstyle in sdk-platform-java-config #2335

Merged
merged 1 commit into from Jan 3, 2024

Conversation

mpeddada1
Copy link
Contributor

The checkstyle was initially disabled to address the following error when executing mvn clean install:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.3.1:check (checkstyle) on project sdk-platform-java-config: Failed during checkstyle execution: Unable to find configuration file at location: license-checks.xml: Could not find resource 'license-checks.xml'. -> [Help 1]

However, since this artifact is meant to be used as a parent for downstream libraries, there is a risk that the checkstyle.skip property will be inherited by child poms in the future. This may cause checkstyle to be unintentionally disabled.

@mpeddada1 mpeddada1 requested a review from a team as a code owner January 3, 2024 20:22
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 3, 2024
Copy link

sonarcloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mpeddada1 mpeddada1 added the automerge Merge the pull request once unit tests and other checks pass. label Jan 3, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 285bdb1 into main Jan 3, 2024
38 of 39 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the enable-checkstyle branch January 3, 2024 21:08
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants