Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove @BetaApi from ApiFutures and ApiService #2454

Merged
merged 4 commits into from Feb 29, 2024
Merged

fix: remove @BetaApi from ApiFutures and ApiService #2454

merged 4 commits into from Feb 29, 2024

Conversation

zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Feb 8, 2024

…ate and Listener.
fixes #2098

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Feb 8, 2024
@zhumin8 zhumin8 marked this pull request as ready for review February 23, 2024 14:53
@zhumin8 zhumin8 requested a review from a team as a code owner February 23, 2024 14:53
@zhumin8 zhumin8 requested a review from lqiu96 February 23, 2024 14:54
@burkedavison
Copy link
Contributor

LGTM. @blakeli0 is back tomorrow, so looking for his approval.

Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@blakeli0 blakeli0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please fix the typo in the title and make the title shorter before merging.

@zhumin8 zhumin8 changed the title fix: remote @BetaApi from ApiFutures.catchingAsync and ApiService St… fix: remove @BetaApi from ApiFutures and ApiService Feb 29, 2024
@zhumin8 zhumin8 merged commit f59e717 into main Feb 29, 2024
40 checks passed
@zhumin8 zhumin8 deleted the fix-2098 branch February 29, 2024 12:59
zhumin8 pushed a commit that referenced this pull request Feb 29, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>2.36.0</summary>

##
[2.36.0](v2.35.0...v2.36.0)
(2024-02-29)


### Features

* check library_name is unique among libraries
([#2490](#2490))
([8123f0b](8123f0b))


### Bug Fixes

* cleanup @BetaApi from Resource Name Builder Methods
([#2450](#2450))
([6e8d098](6e8d098)),
closes
[#2099](#2099)
* Fix watchdog to start with WAITING state
([#2468](#2468))
([dedc40f](dedc40f))
* ignore comment in BUILD
([#2492](#2492))
([6ca20e5](6ca20e5))
* remove @BetaApi from ApiFutures and ApiService
([#2454](#2454))
([f59e717](f59e717)),
closes
[#2098](#2098)


### Dependencies

* grandfathering the dependencies for java-pubsublite and java-bigquery
([#2504](#2504))
([9ceab23](9ceab23))
* update dependency gradle to v7.6.4
([#2474](#2474))
([607dc59](607dc59))
* update dependency org.graalvm.sdk:graal-sdk to v22.3.5
([#2475](#2475))
([2de487b](2de487b))
* update grpc dependencies to v1.62.2
([#2506](#2506))
([f438603](f438603))


### Documentation

* Add contribution guidelines.
([#2045](#2045))
([9939b43](9939b43))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api-common: Remove @BetaApi from ApiFutures.catchingAsync and ApiService classes
3 participants