Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow README generation to be skipped #209

Closed
bcoe opened this issue Mar 27, 2019 · 3 comments
Closed

allow README generation to be skipped #209

bcoe opened this issue Mar 27, 2019 · 3 comments
Assignees
@bcoe
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@bcoe
Copy link
Contributor

bcoe commented Mar 27, 2019

https://github.com/googleapis/google-api-nodejs-client has a fairly bespoke README.md file, which we don't want to be repeatedly rewritten when synthtool is run on the repo. We should provide a mechanism for turning off README generation.
@bcoe bcoe self-assigned this Mar 27, 2019
@JustinBeckwith
Copy link
Contributor

We have that! It's the excludes property:
https://github.com/googleapis/google-api-nodejs-client/blob/master/synth.py#L27

@bcoe
Copy link
Contributor Author

bcoe commented Mar 27, 2019

awesome, I’ll keep this open until I land a patch to exclude READMEs from the node client.

@bcoe bcoe mentioned this issue Mar 27, 2019
Merged
3 tasks
@bcoe
Copy link
Contributor Author

bcoe commented Mar 27, 2019

addressed here: googleapis/google-api-nodejs-client#1657

@bcoe bcoe closed this as completed Mar 27, 2019
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcoe bcoe

Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bcoe @JustinBeckwith @yoshi-automation