Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore fbclid by default when matching precached URLs #2532

Merged
merged 2 commits into from Jun 10, 2020
Merged

Ignore fbclid by default when matching precached URLs #2532

merged 2 commits into from Jun 10, 2020

Conversation

jeffposnick
Copy link
Contributor

R: @philipwalton

Fixes #2417

This adds fbclid to the default list of URL query parameters that should be ignored when matching against precached URLs.

philipwalton
philipwalton approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@philipwalton philipwalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the issue in the test has been resolved.

test/workbox-precaching/integration/test-precache-and-update.js Outdated Show resolved Hide resolved
@jeffposnick jeffposnick merged commit 8b36eeb into v6 Jun 10, 2020
@jeffposnick jeffposnick deleted the ignore-fbclid branch June 10, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipwalton philipwalton philipwalton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add fbclid to default-ignored URL caching parameters?
2 participants
@jeffposnick @philipwalton