Preserve symbols across builds, don't mangle _handle #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @philipwalton
Fixes #1674, #2686
This uses the
tersernameCacheoption, backed by a module-scoped variable to store the cache in-memory. Because it's not persisted to disk, this will only work as expecting if we build all the packages within the same process, but that's what's we do during our releases, so I think that's fine.This also exempts
_handlefrom the list of properties that are eligible for renaming, since it's part of the public API.There are no new tests for this change—Phil, if you know of any similar tests that seem suitable for adapting, let me know.