Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing durability to relaxed #2934

Merged
merged 4 commits into from Sep 7, 2021
Merged

changing durability to relaxed #2934

merged 4 commits into from Sep 7, 2021

Conversation

tropicadri
Copy link
Collaborator

After reading #2854 and this article, seeing it is the default behavior in FF that seems to improve the performance, that is supported in Chrome and seems to be soon supported in Safari, I think it is a good idea to change the durability.

Fixes #2854

Copy link
Contributor

@jeffposnick jeffposnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also write to IndexedDB (via add() instead of put()) at:

async addEntry(entry: UnidentifiedQueueStoreEntry): Promise<void> {
const db = await this.getDb();
await db.add(REQUEST_OBJECT_STORE_NAME, entry as QueueStoreEntry);
}

Should that be moved inside a transaction with relaxed durability as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider durability: relaxed for indexeddb writes
2 participants