Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 on FAQ link in main branch docs. #443

Closed
markmandel opened this issue Nov 23, 2021 · 4 comments
Closed

404 on FAQ link in main branch docs. #443

markmandel opened this issue Nov 23, 2021 · 4 comments
Labels
kind/bug Something isn't working kind/documentation Improvements or additions to documentation

Comments

@markmandel
Copy link
Member

What happened:

404 when trying to reach FAQ from the sidebar:
https://googleforgames.github.io/quilkin/main/book/

image

What you expected to happen:

It to take me to the page.

How to reproduce it (as minimally and precisely as possible):

Click the above link, and then click "FAQ".

Anything else we need to know?:

This works fine for the 0.2.0 guide.
Also, I can't seem to reproduce this locally.

In https://github.com/googleforgames/quilkin/tree/gh-pages/main/book it's got a FAQ.html (which is incorrect), but in https://github.com/googleforgames/quilkin/tree/gh-pages/v0.2.0/book we can see it's faq.html. Locally I'm also getting faq.html - so I'm very confused.

Environment: Github Actions

  • Quilkin version: dev
  • Execution environment (binary, container, etc): Github Actions
  • Operating system: N/A
  • Custom filters? (Yes/No - if so, what do they do?): N/A
  • Log(s): N/A
  • Others: N/A
@markmandel markmandel added kind/bug Something isn't working kind/documentation Improvements or additions to documentation labels Nov 23, 2021
@markmandel
Copy link
Member Author

@XAMPPRocky I know you've done a lot of stuff with GH Actions and mdbook -- you seen this before? Is it possible that for some reason the gh pages action isn't seeing a change in FAQ vs faq, and not updating the page?

@markmandel
Copy link
Member Author

AHA!

I am wondering if we should manually delete FAQ.html from the github branch for main, so it can be replaced. Any objections?

@markmandel
Copy link
Member Author

I did a dumb, and accidentally pushed to gh-pages on googleforgames/quilkin (I didn't realise I didn't have it set as upstream instead of origin).

Happy to revert and submit as a PR instead if someone has strong feelings.
59c65c6

https://googleforgames.github.io/quilkin/main/book/faq.html now works though.

@markmandel
Copy link
Member Author

Looks like nobody minds that I did a silly 😄 in which case, I'll close this issue 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working kind/documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant