You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@inhere I'm still working on it. The regex in the other repo has some issues as well. What I'm trying to do is: instead of using a complex regex, I'm thinking of updating the method like this
Describe the bug
Currently,
fullUrl
returns invalid URLs as valid ones. Same is the case withUrl
. We should improve the regex like here:https://github.com/asaskevich/govalidator/blob/master/patterns.go#L41
Examples:
To Reproduce
Add the above invalid URLs to
TestIsFullURL
function, the tests will pass.The text was updated successfully, but these errors were encountered: