Commit
closes #3044 What happens is that, if the tag is created only locally, it'll create the tag in the remote upon creating the release. The tag still needs to be created locally though! @bep let me know if that works for you. Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -217,11 +217,12 @@ func (c *githubClient) CreateRelease(ctx *context.Context, body string) (string, | |
body = truncateReleaseBody(body) | ||
|
||
data := &github.RepositoryRelease{ | ||
Name: github.String(title), | ||
TagName: github.String(ctx.Git.CurrentTag), | ||
Body: github.String(body), | ||
Draft: github.Bool(ctx.Config.Release.Draft), | ||
Prerelease: github.Bool(ctx.PreRelease), | ||
Name: github.String(title), | ||
TagName: github.String(ctx.Git.CurrentTag), | ||
TargetCommitish: github.String(ctx.Git.Commit), | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
caarlos0
Author
Member
|
||
Body: github.String(body), | ||
Draft: github.Bool(ctx.Config.Release.Draft), | ||
Prerelease: github.Bool(ctx.PreRelease), | ||
} | ||
if ctx.Config.Release.DiscussionCategoryName != "" { | ||
data.DiscussionCategoryName = github.String(ctx.Config.Release.DiscussionCategoryName) | ||
|
Heads up:
github.String
is a string pointer, I suspect the 422 (or something) people got last time you tried this was because they had empty string values in their config, which is non-nil.