Skip to content

Commit

Permalink
fix: do not set default builds
Browse files Browse the repository at this point in the history
closes #1294

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
  • Loading branch information
caarlos0 committed Jan 8, 2020
1 parent f4d4dc6 commit c63a57e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
5 changes: 0 additions & 5 deletions internal/pipe/docker/docker.go
Expand Up @@ -55,11 +55,6 @@ func (Pipe) Default(ctx *context.Context) error {
ctx.Config.Builds[0].Binary,
}
}
if len(ctx.Config.Dockers[0].Builds) == 0 {
ctx.Config.Dockers[0].Builds = []string{
ctx.Config.Builds[0].ID,
}
}
if ctx.Config.Dockers[0].Dockerfile == "" {
ctx.Config.Dockers[0].Dockerfile = "Dockerfile"
}
Expand Down
1 change: 1 addition & 0 deletions internal/pipe/docker/docker_test.go
Expand Up @@ -723,6 +723,7 @@ func TestDefault(t *testing.T) {
assert.Equal(t, "linux", docker.Goos)
assert.Equal(t, "amd64", docker.Goarch)
assert.Equal(t, []string{ctx.Config.Builds[0].Binary}, docker.Binaries)
assert.Empty(t, docker.Builds)
}

func TestDefaultBinaries(t *testing.T) {
Expand Down

0 comments on commit c63a57e

Please sign in to comment.