Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
fix: log duration of padlog steps (#3439)
Sub-steps of the publish steps do not have the *took:* log, this will
fix it.

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
  • Loading branch information
caarlos0 committed Oct 5, 2022
1 parent e89e213 commit d9928fe
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions internal/middleware/logging/logging.go
Expand Up @@ -20,9 +20,7 @@ func Log(title string, next middleware.Action) middleware.Action {
return func(ctx *context.Context) error {
start := time.Now()
defer func() {
if took := time.Since(start).Round(time.Second); took > 0 {
log.Info(faint.Render(fmt.Sprintf("took: %s", took)))
}
logDuration(start)
log.ResetPadding()
}()
log.Infof(bold.Render(title))
Expand All @@ -34,11 +32,21 @@ func Log(title string, next middleware.Action) middleware.Action {
// PadLog pretty prints the given action and its title with an increased padding.
func PadLog(title string, next middleware.Action) middleware.Action {
return func(ctx *context.Context) error {
defer log.ResetPadding()
start := time.Now()
defer func() {
logDuration(start)
log.ResetPadding()
}()
log.ResetPadding()
log.IncreasePadding()
log.Infof(bold.Render(title))
log.IncreasePadding()
return next(ctx)
}
}

func logDuration(start time.Time) {
if took := time.Since(start).Round(time.Second); took > 0 {
log.Info(faint.Render(fmt.Sprintf("took: %s", took)))
}
}

0 comments on commit d9928fe

Please sign in to comment.