feat: use proxy from environment (#1885)

* feat: use proxy from environment Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com> * Update internal/client/github.go Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
goreleaser · Nov 5, 2020 · f1049b9 · f1049b9 · vercel · Nov 5, 2020
1 parent 032a105
commit f1049b9
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 0 deletions.
diff --git a/internal/client/gitea.go b/internal/client/gitea.go
@@ -40,6 +40,7 @@ func NewGitea(ctx *context.Context, token string) (Client, error) {
 		return nil, err
 	}
 	transport := &http.Transport{
+		Proxy: http.ProxyFromEnvironment,
 		TLSClientConfig: &tls.Config{
 			// nolint: gosec
 			InsecureSkipVerify: ctx.Config.GiteaURLs.SkipTLSVerify,

diff --git a/internal/client/github.go b/internal/client/github.go
@@ -38,6 +38,7 @@ func NewGitHub(ctx *context.Context, token string) (Client, error) {
 	base.(*http.Transport).TLSClientConfig = &tls.Config{
 		InsecureSkipVerify: ctx.Config.GitHubURLs.SkipTLSVerify,
 	}
+	base.(*http.Transport).Proxy = http.ProxyFromEnvironment
 	httpClient.Transport.(*oauth2.Transport).Base = base
 	client := github.NewClient(httpClient)
 	if ctx.Config.GitHubURLs.API != "" {

diff --git a/internal/client/gitlab.go b/internal/client/gitlab.go
@@ -28,6 +28,7 @@ type gitlabClient struct {
 // NewGitLab returns a gitlab client implementation.
 func NewGitLab(ctx *context.Context, token string) (Client, error) {
 	transport := &http.Transport{
+		Proxy: http.ProxyFromEnvironment,
 		TLSClientConfig: &tls.Config{
 			// nolint: gosec
 			InsecureSkipVerify: ctx.Config.GitLabURLs.SkipTLSVerify,

diff --git a/internal/http/http.go b/internal/http/http.go
@@ -311,6 +311,7 @@ func getHTTPClient(upload *config.Upload) (*h.Client, error) {
 	pool.AppendCertsFromPEM([]byte(upload.TrustedCerts)) // already validated certs checked by CheckConfig
 	return &h.Client{
 		Transport: &h.Transport{
+			Proxy: h.ProxyFromEnvironment,
 			TLSClientConfig: &tls.Config{ // nolint: gosec
 				RootCAs: pool,
 			},