Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wasm support #1159

Merged
merged 1 commit into from Oct 1, 2019
Merged

feat: wasm support #1159

merged 1 commit into from Oct 1, 2019

Conversation

caarlos0
Copy link
Member

adds JS WASM build target.

closes #1017

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@codecov-io
Copy link

codecov-io commented Sep 27, 2019

Codecov Report

Merging #1159 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1159      +/-   ##
==========================================
+ Coverage   82.98%   82.99%   +0.01%     
==========================================
  Files          58       58              
  Lines        3262     3264       +2     
==========================================
+ Hits         2707     2709       +2     
  Misses        473      473              
  Partials       82       82
Impacted Files Coverage Δ
internal/builders/golang/targets.go 100% <ø> (ø) ⬆️
internal/pipe/build/build.go 97.64% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aae030...78fca35. Read the comment docs.

@caarlos0 caarlos0 changed the title wip: feat: wasm support feat: wasm support Sep 27, 2019
@caarlos0
Copy link
Member Author

Not sure if this is enough, as I don't really use wasm et al... it does work though 🤔

@caarlos0 caarlos0 mentioned this pull request Sep 27, 2019
6 tasks
@caarlos0 caarlos0 merged commit 9d5f36f into master Oct 1, 2019
@caarlos0 caarlos0 deleted the wasm branch October 1, 2019 19:00
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support releasing WASM builds
2 participants