Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support additional GOOS/GOARCH targets #1162

Merged
merged 3 commits into from Oct 1, 2019

Conversation

maier
Copy link
Contributor

@maier maier commented Oct 1, 2019

Add support for additional targets:

GOOS=illumos GOARCH=amd64
GOOS=aix GOARCH=ppc64
GOOS=android GOARCH=386
GOOS=android GOARCH=amd64
GOOS=android GOARCH=arm64
GOOS=plan9 GOARCH=arm

@maier
Copy link
Contributor Author

maier commented Oct 1, 2019

@caarlos0 I just noticed issue 1160, I can add the remaining new GOOS/GOARCH combos from go1.13 to this PR if you'd like. (sans jswasm which you have in another PR.)

@caarlos0
Copy link
Member

caarlos0 commented Oct 1, 2019

that would be awesome. I did jswasm in another pr because it needed more things (.wasm ext), if that's not the case with the others, feel free to do it.

FWIW will merge that PR as well.

Thanks 🚀

@codecov-io
Copy link

codecov-io commented Oct 1, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@9d5f36f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1162   +/-   ##
=========================================
  Coverage          ?   82.99%           
=========================================
  Files             ?       58           
  Lines             ?     3264           
  Branches          ?        0           
=========================================
  Hits              ?     2709           
  Misses            ?      473           
  Partials          ?       82
Impacted Files Coverage Δ
internal/builders/golang/targets.go 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d5f36f...cba8d67. Read the comment docs.

@maier maier changed the title feat: support illumos amd64 target feat: support additional GOOS/GOARCH targets Oct 1, 2019
@caarlos0 caarlos0 merged commit 9b5df03 into goreleaser:master Oct 1, 2019
@caarlos0
Copy link
Member

caarlos0 commented Oct 1, 2019

Thanks!

@caarlos0
Copy link
Member

caarlos0 commented Oct 1, 2019

closes #1160

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants