Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getTag return incorrect tag, if we have more than 1 tag for 1 commit #1164

Merged
merged 5 commits into from Oct 7, 2019

Conversation

andriisoldatenko
Copy link
Contributor

Possible fix of #1163

@caarlos0
Copy link
Member

caarlos0 commented Oct 5, 2019

build is failing...

@caarlos0 caarlos0 changed the title getTag return incorrect tag, if we have more than 1 tag for 1 commit fix: getTag return incorrect tag, if we have more than 1 tag for 1 commit Oct 7, 2019
@codecov-io
Copy link

codecov-io commented Oct 7, 2019

Codecov Report

Merging #1164 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1164   +/-   ##
=======================================
  Coverage   83.62%   83.62%           
=======================================
  Files          58       58           
  Lines        3292     3292           
=======================================
  Hits         2753     2753           
  Misses        457      457           
  Partials       82       82
Impacted Files Coverage Δ
internal/pipe/git/git.go 95% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39d07c3...639f9fc. Read the comment docs.

@andriisoldatenko
Copy link
Contributor Author

@caarlos0 fixed.

@caarlos0 caarlos0 merged commit 2403a40 into goreleaser:master Oct 7, 2019
@caarlos0
Copy link
Member

caarlos0 commented Oct 7, 2019

awesome, thanks!

@caarlos0
Copy link
Member

will need to revert this, check #1211

caarlos0 added a commit that referenced this pull request Oct 21, 2019
@andriisoldatenko
Copy link
Contributor Author

@caarlos0 checking...

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants