Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reject docker.files as . or inside dist #1175

Merged
merged 3 commits into from Oct 6, 2019
Merged

fix: reject docker.files as . or inside dist #1175

merged 3 commits into from Oct 6, 2019

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Oct 6, 2019

prevent setting docker.files to . or something inside ./dist, hence not allowing "infinite path loops"

closes #1117

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@codecov-io
Copy link

codecov-io commented Oct 6, 2019

Codecov Report

Merging #1175 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1175      +/-   ##
=========================================
+ Coverage   83.08%   83.1%   +0.01%     
=========================================
  Files          58      58              
  Lines        3282    3285       +3     
=========================================
+ Hits         2727    2730       +3     
  Misses        473     473              
  Partials       82      82
Impacted Files Coverage Δ
internal/pipe/docker/docker.go 92.89% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 792b883...70380cb. Read the comment docs.

@caarlos0 caarlos0 merged commit 4233084 into master Oct 6, 2019
@caarlos0 caarlos0 deleted the docker-files branch October 6, 2019 20:09
@raxod502
Copy link

raxod502 commented Oct 6, 2019

Does this actually fix the problem #1117? I.e. is it now possible to build a Docker image that requires all of the project files in .?

@caarlos0
Copy link
Member Author

caarlos0 commented Oct 6, 2019

No, no clean way to fix it right now, you can put all files you need inside another folder and add that instead.

@raxod502
Copy link

raxod502 commented Oct 6, 2019

In that case can we keep the issue open since the problem isn't really fixed?

@caarlos0
Copy link
Member Author

caarlos0 commented Oct 6, 2019

it will not be fixed, at least not now...

to maybe fix that it would require a lot of refactory on the docker pipe, and adding the entire folder is not very common as goreleaser built docker images are usually just install deps and copy the binary...

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'file name too long' when using '.' as 'extra_files'
3 participants