Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip aware semerrgroup #1176

Merged
merged 2 commits into from Oct 6, 2019
Merged

fix: skip aware semerrgroup #1176

merged 2 commits into from Oct 6, 2019

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Oct 6, 2019

added a skipAwareGroup to semerrgroup pkg, which decorates a Group adding the ability to proceed even with a pipe.SkipErr and returning the first skip err OR another error in case it happens.

refs #1053

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@codecov-io
Copy link

codecov-io commented Oct 6, 2019

Codecov Report

Merging #1176 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1176      +/-   ##
==========================================
+ Coverage   82.99%   83.08%   +0.09%     
==========================================
  Files          58       58              
  Lines        3264     3282      +18     
==========================================
+ Hits         2709     2727      +18     
  Misses        473      473              
  Partials       82       82
Impacted Files Coverage Δ
internal/semerrgroup/sem.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50235f2...beefd5c. Read the comment docs.

@caarlos0 caarlos0 merged commit d338cf7 into master Oct 6, 2019
@caarlos0 caarlos0 deleted the docker-err branch October 6, 2019 17:58
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants