Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker: skip push skips other builds #1177

Merged
merged 3 commits into from Oct 6, 2019
Merged

fix: docker: skip push skips other builds #1177

merged 3 commits into from Oct 6, 2019

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Oct 6, 2019

closes #1053

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@codecov-io
Copy link

codecov-io commented Oct 6, 2019

Codecov Report

Merging #1177 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1177   +/-   ##
=======================================
  Coverage   83.08%   83.08%           
=======================================
  Files          58       58           
  Lines        3282     3282           
=======================================
  Hits         2727     2727           
  Misses        473      473           
  Partials       82       82
Impacted Files Coverage Δ
internal/pipe/docker/docker.go 92.77% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d338cf7...9c2b9c9. Read the comment docs.

@caarlos0 caarlos0 merged commit 792b883 into master Oct 6, 2019
@caarlos0 caarlos0 deleted the dockerr branch October 6, 2019 18:53
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No error if a single dockers step fails
2 participants