Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: git diff when dirty (#1178)" #1208

Merged
merged 1 commit into from Oct 20, 2019
Merged

Revert "feat: git diff when dirty (#1178)" #1208

merged 1 commit into from Oct 20, 2019

Conversation

caarlos0
Copy link
Member

git diff does not work when we have untracked files.

@caarlos0 caarlos0 merged commit 89e3a55 into master Oct 20, 2019
@caarlos0 caarlos0 deleted the diff branch October 20, 2019 14:15
@codecov-io
Copy link

codecov-io commented Oct 20, 2019

Codecov Report

Merging #1208 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1208      +/-   ##
==========================================
+ Coverage   83.62%   83.65%   +0.02%     
==========================================
  Files          58       58              
  Lines        3292     3285       -7     
==========================================
- Hits         2753     2748       -5     
+ Misses        457      456       -1     
+ Partials       82       81       -1
Impacted Files Coverage Δ
internal/pipe/git/git.go 97.26% <100%> (+2.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7151b99...4e71977. Read the comment docs.

@caarlos0
Copy link
Member Author

refs #1206

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants