Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added new flags to support release notes header and footer. #1212

Merged
merged 12 commits into from Nov 15, 2019

Conversation

jnovikov
Copy link
Contributor

Created two flags for release generation.
--release-footer
--release-header
These flags can help you to add custom changelog text before/after changes that are generated by git log.

This commit is based on this issue:
#1131

Created two flags for release generation.
--release-footer
--release-header
These flags can help you to add custom changelog text before/after changes that are generated by git log.
@jnovikov jnovikov changed the title Added new flags to support release notes header and footer. feat: Added new flags to support release notes header and footer. Oct 21, 2019
@codecov-io
Copy link

codecov-io commented Oct 22, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@4719763). Click here to learn what that means.
The diff coverage is 63.88%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1212   +/-   ##
=========================================
  Coverage          ?   83.66%           
=========================================
  Files             ?       58           
  Lines             ?     3311           
  Branches          ?        0           
=========================================
  Hits              ?     2770           
  Misses            ?      460           
  Partials          ?       81
Impacted Files Coverage Δ
pkg/context/context.go 100% <ø> (ø)
internal/pipe/changelog/changelog.go 98.27% <100%> (ø)
main.go 48.85% <13.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4719763...ea3628d. Read the comment docs.

@caarlos0
Copy link
Member

I'll take a look at some point, sorry for the delay so far

Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, just a few comments there :)

internal/pipe/changelog/changelog.go Outdated Show resolved Hide resolved
internal/pipe/changelog/changelog.go Outdated Show resolved Hide resolved
@caarlos0 caarlos0 merged commit 16cb4d8 into goreleaser:master Nov 15, 2019
@caarlos0
Copy link
Member

Thanks @jnovikov and so sorry for the delay 🙏

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants