Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter by id on sign pipe #1233

Merged
merged 1 commit into from Nov 8, 2019
Merged

feat: filter by id on sign pipe #1233

merged 1 commit into from Nov 8, 2019

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Nov 8, 2019

ads the hability to filter by id on the sign pipe.

with this, the user can have multiple build configs, say, one specifically for macos, then one archive config specifically for it, and finally a sign config for it, signing it with gon, so it macOS won't complain when the user tries to run it.

refs #1227

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@codecov-io
Copy link

codecov-io commented Nov 8, 2019

Codecov Report

Merging #1233 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1233      +/-   ##
==========================================
+ Coverage   83.65%   83.66%   +<.01%     
==========================================
  Files          58       58              
  Lines        3286     3287       +1     
==========================================
+ Hits         2749     2750       +1     
  Misses        456      456              
  Partials       81       81
Impacted Files Coverage Δ
pkg/config/config.go 100% <ø> (ø) ⬆️
internal/pipe/sign/sign.go 94.87% <100%> (+0.06%) ⬆️
internal/artifact/artifact.go 83.62% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d95590...4940d0a. Read the comment docs.

@caarlos0 caarlos0 merged commit 4719763 into master Nov 8, 2019
@caarlos0 caarlos0 deleted the filter-sign branch November 8, 2019 12:10
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants