Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for c-shared and c-archive build modes in windows #1243

Merged
merged 3 commits into from Nov 15, 2019
Merged

feat: Add support for c-shared and c-archive build modes in windows #1243

merged 3 commits into from Nov 15, 2019

Conversation

qmuntal
Copy link
Contributor

@qmuntal qmuntal commented Nov 15, 2019

This PR modifies the default extension of windows that are build using the flag -buildmode=c-shared and -buildmode=c-archive from .exe to .dll and .lib, respectively.

Even though go allows other non-.exe build modes (archive, shared, pie and plugin), these are not supported in windows.

More info about build modes: https://golang.org/cmd/go/#hdr-Build_modes

This commit is based on this issue:
#1221

@caarlos0
Copy link
Member

closes #1221

@codecov-io
Copy link

codecov-io commented Nov 15, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@16cb4d8). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1243   +/-   ##
=========================================
  Coverage          ?   83.68%           
=========================================
  Files             ?       58           
  Lines             ?     3316           
  Branches          ?        0           
=========================================
  Hits              ?     2775           
  Misses            ?      460           
  Partials          ?       81
Impacted Files Coverage Δ
internal/pipe/build/build.go 97.77% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16cb4d8...f61ad6b. Read the comment docs.

@caarlos0 caarlos0 merged commit 1cf86b8 into goreleaser:master Nov 15, 2019
@caarlos0
Copy link
Member

Awesome, thanks!

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants