Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nfpm): allow to change package name #1244

Merged
merged 2 commits into from Nov 15, 2019
Merged

feat(nfpm): allow to change package name #1244

merged 2 commits into from Nov 15, 2019

Conversation

caarlos0
Copy link
Member

  • adds package_name field to nfpm
  • adds file_name_template to nfpm, deprecates name_template

closes #1238

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@codecov-io
Copy link

codecov-io commented Nov 15, 2019

Codecov Report

Merging #1244 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1244      +/-   ##
=========================================
+ Coverage   83.66%   83.7%   +0.04%     
=========================================
  Files          58      58              
  Lines        3311    3321      +10     
=========================================
+ Hits         2770    2780      +10     
  Misses        460     460              
  Partials       81      81
Impacted Files Coverage Δ
pkg/config/config.go 100% <ø> (ø) ⬆️
internal/pipe/nfpm/nfpm.go 92.75% <100%> (+0.27%) ⬆️
internal/pipe/build/build.go 97.77% <0%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16cb4d8...88afebd. Read the comment docs.

@caarlos0 caarlos0 changed the title feat: allow to change package name feat(nfpm): allow to change package name Nov 15, 2019
@caarlos0 caarlos0 merged commit 0953c2f into master Nov 15, 2019
@caarlos0 caarlos0 deleted the nfpm branch November 15, 2019 19:00
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Name template not working for rpm metadata.
2 participants