New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: http POST #1246
feat: http POST #1246
Conversation
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1246 +/- ##
==========================================
- Coverage 83.76% 83.66% -0.11%
==========================================
Files 58 58
Lines 3320 3342 +22
==========================================
+ Hits 2781 2796 +15
- Misses 459 463 +4
- Partials 80 83 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the cosmetic changes I suggested in comments, LGTM.
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This would allow to send HTTP POSTs as well instead of only PUTs.
refs #1204