Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: http POST #1246

Merged
merged 8 commits into from Nov 18, 2019
Merged

feat: http POST #1246

merged 8 commits into from Nov 18, 2019

Conversation

caarlos0
Copy link
Member

This would allow to send HTTP POSTs as well instead of only PUTs.

refs #1204

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@codecov-io
Copy link

codecov-io commented Nov 15, 2019

Codecov Report

Merging #1246 into master will decrease coverage by 0.1%.
The diff coverage is 91.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1246      +/-   ##
==========================================
- Coverage   83.76%   83.66%   -0.11%     
==========================================
  Files          58       58              
  Lines        3320     3342      +22     
==========================================
+ Hits         2781     2796      +15     
- Misses        459      463       +4     
- Partials       80       83       +3
Impacted Files Coverage Δ
pkg/config/config.go 100% <ø> (ø) ⬆️
internal/pipe/publish/publish.go 84.61% <ø> (ø) ⬆️
internal/pipe/artifactory/artifactory.go 100% <100%> (ø) ⬆️
internal/pipe/upload/upload.go 83.33% <70%> (ø)
internal/http/http.go 90.24% <94.73%> (-1.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 173edba...7ea99df. Read the comment docs.

internal/http/http.go Outdated Show resolved Hide resolved
internal/http/http.go Outdated Show resolved Hide resolved
internal/http/http.go Outdated Show resolved Hide resolved
Copy link
Contributor

@lalloni lalloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the cosmetic changes I suggested in comments, LGTM.

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 merged commit b0481a1 into master Nov 18, 2019
@caarlos0 caarlos0 deleted the http branch November 18, 2019 13:34
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants