Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change default snapshot version template #1248

Merged
merged 1 commit into from Nov 15, 2019
Merged

feat: change default snapshot version template #1248

merged 1 commit into from Nov 15, 2019

Conversation

caarlos0
Copy link
Member

both deb and rpm requires that the version is somewhat semantic, so this is a way to make that work as expected.

closes #1236

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #1248 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1248   +/-   ##
======================================
  Coverage    83.7%   83.7%           
======================================
  Files          58      58           
  Lines        3321    3321           
======================================
  Hits         2780    2780           
  Misses        460     460           
  Partials       81      81
Impacted Files Coverage Δ
internal/pipe/snapshot/snapshot.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0953c2f...8143d85. Read the comment docs.

@caarlos0 caarlos0 merged commit 173edba into master Nov 15, 2019
@caarlos0 caarlos0 deleted the nfpm-snap branch November 15, 2019 21:23
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edge case in DEB package version
2 participants