Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fully support all s3 pipe feats on blob #1253

Merged
merged 4 commits into from Nov 20, 2019
Merged

feat: fully support all s3 pipe feats on blob #1253

merged 4 commits into from Nov 20, 2019

Conversation

caarlos0
Copy link
Member

  • added blobs.endpoint config
  • make bucket template-able as the docs states
  • copied s3 pipe's tests into blob package, all passing
  • updated gocloud lib

refs #1223

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@codecov-io
Copy link

codecov-io commented Nov 20, 2019

Codecov Report

Merging #1253 into master will increase coverage by 0.1%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1253     +/-   ##
=========================================
+ Coverage   83.66%   83.77%   +0.1%     
=========================================
  Files          58       58             
  Lines        3342     3346      +4     
=========================================
+ Hits         2796     2803      +7     
+ Misses        463      461      -2     
+ Partials       83       82      -1
Impacted Files Coverage Δ
pkg/config/config.go 100% <ø> (ø) ⬆️
internal/pipe/blob/blob.go 100% <100%> (+6.06%) ⬆️
internal/pipe/blob/openbucket.go 56.81% <80%> (+5.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0481a1...78b4ded. Read the comment docs.

@jonfriesen
Copy link

fixes #1223
thank-you!

@caarlos0 caarlos0 merged commit 2dc3ae3 into master Nov 20, 2019
@caarlos0 caarlos0 deleted the blob-minio branch November 20, 2019 16:08
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants