Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port new nfpm options into goreleaser #1829

Closed
caarlos0 opened this issue Oct 1, 2020 · 2 comments · Fixed by #1849
Closed

port new nfpm options into goreleaser #1829

caarlos0 opened this issue Oct 1, 2020 · 2 comments · Fixed by #1849
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed

Comments

@caarlos0
Copy link
Member

caarlos0 commented Oct 1, 2020

gorelaser is behind nfpm in options, mostly regarding signing packages.

we need to port and document them.
@caarlos0 caarlos0 added enhancement New feature or request help wanted Extra attention is needed hacktoberfest labels Oct 1, 2020
@caarlos0 caarlos0 mentioned this issue Oct 1, 2020
Closed
@caarlos0 caarlos0 changed the title port new nfpm option into goreleaser port new nfpm options into goreleaser Oct 6, 2020
jonathanlloyd added a commit to jonathanlloyd/goreleaser that referenced this issue Oct 10, 2020
@jonathanlloyd
feat: Add deb packager-specific nfpm config (goreleaser#1829)
c20545b
@jonathanlloyd jonathanlloyd mentioned this issue Oct 10, 2020
Merged
@jonathanlloyd
Copy link
Contributor

Hey! I've started having a go at this in #1849
I've only done the deb config to start with to check with you that I'm headed in the right direction.
If so, I'll take a look at adding rpm and apk as well

Happy Hacktoberfest! 🎃

jonathanlloyd added a commit to jonathanlloyd/goreleaser that referenced this issue Oct 10, 2020
@jonathanlloyd
feat: Add deb packager-specific nfpm config (goreleaser#1829)
1449777
@caarlos0 caarlos0 mentioned this issue Oct 23, 2020
Closed
caarlos0 pushed a commit that referenced this issue Nov 5, 2020
@jonathanlloyd
feat: add packager-specific nfpm config (#1849)
17e5674 
* feat: Add deb packager-specific nfpm config (#1829)

* Use env vars containing nfpm ids for deb pgp passphrase

* Add docs for nfpm id in env var

* Custon -> Custom

* Switch test cases

* Forward RPM specific config to nfpm

* Document rpm-specific nfpm config

* Add APK-specific nfpm config

* Document apk-specific nfpm config

* avaiable -> available

* Add deb scripts templates to nfpm config
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add packager-specific nfpm config (#1829) jonathanlloyd/goreleaser
2 participants
@caarlos0 @jonathanlloyd