Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent checksums file from uploading #1847

Closed
NorseGaud opened this issue Oct 9, 2020 · 8 comments
Closed

Prevent checksums file from uploading #1847

NorseGaud opened this issue Oct 9, 2020 · 8 comments
Labels
enhancement New feature or request

Comments

@NorseGaud
Copy link

Describe the bug

builds:
  - id: builder
    binary: binary-name
    env:
      # Because we want to avoid coupling to system libraries.
      - CGO_ENABLED=0
    goos:
      - darwin
    goarch:
      - amd64

archives:
  - id: zip
    builds:
      - builder
    format: zip
    name_template: "{{ .ProjectName }}_v{{ .Version }}_{{ .Os }}_{{ .Arch }}{{ if .Arm }}v{{ .Arm }}{{ end }}{{ if .Mips }}_{{ .Mips }}{{ end }}"
    wrap_in_directory: false
    files:
      - none*

checksum:
  name_template: "{{ .ProjectName }}_v{{ .Version }}_checksums.txt"

signs:
  - id: notarize-zip
    signature: "${artifact}.zip"
    cmd: gon
    args:
      - ".gon.hcl"
    artifacts: all
    ids:
      - builder

release:
  ids:
    - none
  extra_files:
    - glob: ./dist/*.zip

Using this yaml, I can notarize my zip/binary. However, the checksums file contents is then different from what the new signed/notarized .zip is.

There should be a way to disable the uploading of the checksums.txt file.

@NorseGaud NorseGaud added the enhancement New feature or request label Oct 9, 2020
@NorseGaud NorseGaud changed the title gon notarization changes zip, so checksums file is wrong Prevent checksums file from uploading Oct 9, 2020
@caarlos0
Copy link
Member

seems like a duplicate of #1802

@caarlos0
Copy link
Member

BTW you can already disable the checksum thing: https://goreleaser.com/customization/checksum/

@NorseGaud
Copy link
Author

@caarlos0 , disabling checksum prevents signing. Is that a bug?

@caarlos0
Copy link
Member

caarlos0 commented Oct 10, 2020

disabling checksum prevents signing. Is that a bug?

yes, seems like a bug 🤔

can you open a new issue with config & perhaps the logs running with --debug? Thanks!

@NorseGaud
Copy link
Author

I’ll follow up after the three day weekend and get you everything you need

👍🏻 Thanks for the help

@NorseGaud
Copy link
Author

Can't replicate :) checksum: disable: true works great.

@caarlos0
Copy link
Member

Thanks @NorseGaud 🙏

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants