Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: validate goos, goarch, goarm and gomips #1886

Merged
merged 3 commits into from Nov 5, 2020
Merged

feat: validate goos, goarch, goarm and gomips #1886

merged 3 commits into from Nov 5, 2020

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Nov 5, 2020

closes #1878

@caarlos0
feat: validate goos, goarch, goarm and gomips
5b1ba33 
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 self-assigned this Nov 5, 2020
@vercel
Copy link

vercel bot commented Nov 5, 2020 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/goreleaser/kevmdx35b
✅ Preview: https://goreleaser-git-arch-validate.goreleaser.vercel.app

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 5, 2020
@caarlos0 caarlos0 mentioned this pull request Nov 5, 2020
Closed
@caarlos0
fix: lint
467457d 
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview November 5, 2020 02:15 Inactive
djgilcrease
djgilcrease approved these changes Nov 5, 2020
View reviewed changes
Copy link

@djgilcrease djgilcrease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel vercel bot temporarily deployed to Preview November 5, 2020 07:07 Inactive
@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #1886 into master will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1886      +/-   ##
==========================================
+ Coverage   81.44%   81.53%   +0.08%     
==========================================
  Files          73       73              
  Lines        3729     3747      +18     
==========================================
+ Hits         3037     3055      +18     
  Misses        570      570              
  Partials      122      122
Impacted Files Coverage Δ
pkg/build/build.go 100.00% <ø> (ø)
internal/builders/golang/build.go 94.24% <100.00%> (+0.12%) ⬆️
internal/builders/golang/targets.go 100.00% <100.00%> (ø)
internal/pipe/build/build.go 98.34% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fafeb9b...dfc2f6f. Read the comment docs.

@kodiakhq kodiakhq bot merged commit 032a105 into master Nov 5, 2020
@kodiakhq kodiakhq bot deleted the arch-validate branch November 5, 2020 07:20
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2020

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@djgilcrease djgilcrease djgilcrease approved these changes

Assignees

@caarlos0 caarlos0

Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid goarch values are ignored
2 participants
@caarlos0 @djgilcrease