Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve completions #1894

Merged
merged 1 commit into from Nov 12, 2020
Merged

fix: improve completions #1894

merged 1 commit into from Nov 12, 2020

Conversation

caarlos0
Copy link
Member

setting arg counts and added long description to completions command.

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 added enhancement New feature or request automerge labels Nov 12, 2020
@caarlos0 caarlos0 self-assigned this Nov 12, 2020
@vercel
Copy link

vercel bot commented Nov 12, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/goreleaser/g1picj33b
✅ Preview: https://goreleaser-git-cmds.goreleaser.vercel.app

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 12, 2020
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #1894 (5aae4a9) into master (c39c820) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1894      +/-   ##
==========================================
+ Coverage   81.65%   81.78%   +0.12%     
==========================================
  Files          73       73              
  Lines        3800     3826      +26     
==========================================
+ Hits         3103     3129      +26     
  Misses        573      573              
  Partials      124      124              
Impacted Files Coverage Δ
cmd/build.go 100.00% <100.00%> (ø)
cmd/check.go 100.00% <100.00%> (ø)
cmd/completion.go 100.00% <100.00%> (ø)
cmd/init.go 90.47% <100.00%> (+0.47%) ⬆️
cmd/release.go 100.00% <100.00%> (ø)
cmd/root.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c39c820...5aae4a9. Read the comment docs.

@kodiakhq kodiakhq bot merged commit 707639f into master Nov 12, 2020
@kodiakhq kodiakhq bot deleted the cmds branch November 12, 2020 20:25
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants