Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont fail if there is a .go directory #1899

Merged
merged 1 commit into from Nov 13, 2020
Merged

fix: dont fail if there is a .go directory #1899

merged 1 commit into from Nov 13, 2020

Conversation

caarlos0
Copy link
Member

closes #1897

@caarlos0
fix: dont fail if there is a .go directory
cd09c8b 
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 added bug Something isn't working automerge labels Nov 13, 2020
@caarlos0 caarlos0 self-assigned this Nov 13, 2020
@vercel
Copy link

vercel bot commented Nov 13, 2020 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/goreleaser/i4dq71kpr
✅ Preview: https://goreleaser-git-build.goreleaser.vercel.app

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 13, 2020
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #1899 (cd09c8b) into master (707639f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1899   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files          73       73           
  Lines        3826     3827    +1     
=======================================
+ Hits         3129     3130    +1     
  Misses        573      573           
  Partials      124      124
Impacted Files Coverage Δ
internal/builders/golang/build.go 94.28% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 707639f...cd09c8b. Read the comment docs.

radeksimko
radeksimko approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, honestly though I would expect such check built into ParseDir natively https://golang.org/src/go/parser/interface.go?s=4327:4460#L125

I can raise an upstream PR, unless you plan to do so.

@kodiakhq kodiakhq bot merged commit 40aa04f into master Nov 13, 2020
@kodiakhq kodiakhq bot deleted the build branch November 13, 2020 13:18
@caarlos0
Copy link
Member Author

I can raise an upstream PR, unless you plan to do so.

already doing hehe

@caarlos0 caarlos0 mentioned this pull request Nov 13, 2020
Closed
gopherbot pushed a commit to golang/go that referenced this pull request Dec 2, 2020
@caarlos0 @griesemer
go/parser: ignore subdirectories in ParseDir
48838c3 
Issue and PR on GoReleaser:
- goreleaser/goreleaser#1897
- goreleaser/goreleaser#1899

Fixes #42951.

Change-Id: Ia0d6018e0bad59cd60cd600188c368c431032a4b
GitHub-Last-Rev: be59d85
GitHub-Pull-Request: #42581
Reviewed-on: https://go-review.googlesource.com/c/go/+/269897
Trust: Robert Griesemer <gri@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
@caarlos0
Copy link
Member Author

caarlos0 commented Dec 3, 2020

PS: this can be reverted once go1.16 is out :)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees

@caarlos0 caarlos0

Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.go directory causes error during release
2 participants
@caarlos0 @radeksimko