Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make generated brew formulas brew audit compatible #1908

Closed
lukasmalkmus opened this issue Nov 18, 2020 · 5 comments
Closed

Make generated brew formulas brew audit compatible #1908

lukasmalkmus opened this issue Nov 18, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@lukasmalkmus
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I'm using goreleaser to release a Homebrew formula for my binary release. I'm using the custom_block config key to set a license field in the resulting formula as well. But when running brew audit on a formula generated by goreleaser, it yields some issues that could easily be omitted:

Trailing whitespace detected.
`license` (line 21) should be put before `bottle` (line 6)

Describe the solution you'd like

I propose two changes:

  1. Just trim the trailing whitespaces. In theory, this should be a no brainer.
  2. Instead of having the license set in the custom_block, make license a first class key in the brews config.

Describe alternatives you've considered

None

Additional context

None


I would love to contribute and make a PR if my issue sounds reasonable.

@lukasmalkmus lukasmalkmus added the enhancement New feature or request label Nov 18, 2020
@caarlos0
Copy link
Member

I remember trying fixing those issues, and then more issues would arise from the fact its not a valid brew formula (its a tap)... and the I just kind of gave up.

But I agree, license should be first class and removing the trailing whitespace should be easy enough to do too.

@lukasmalkmus
Copy link
Contributor Author

Awesome, will figure out a PR on the weekend 👍

lukasmalkmus added a commit to lukasmalkmus/goreleaser that referenced this issue Nov 22, 2020
lukasmalkmus added a commit to lukasmalkmus/goreleaser that referenced this issue Nov 25, 2020
caarlos0 pushed a commit that referenced this issue Nov 26, 2020
…1911)

* feat: add license as first class config key to homebrew (#1908)

* feat: remove trailing whitespace from generated brew formula (#1908)
@lukasmalkmus
Copy link
Contributor Author

Closed by #1911.

@caarlos0
Copy link
Member

Many thanks @lukasmalkmus 🤘

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants