New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make generated brew formulas brew audit
compatible (#1908)
#1911
Conversation
@lukasmalkmus is attempting to deploy a commit to the Goreleaser Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report
@@ Coverage Diff @@
## master #1911 +/- ##
==========================================
- Coverage 81.73% 81.70% -0.04%
==========================================
Files 73 73
Lines 3866 3880 +14
==========================================
+ Hits 3160 3170 +10
- Misses 580 582 +2
- Partials 126 128 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far :)
yeah that's always the worst, maybe we can remove them after compiling the template though 🤔 |
69acb34
to
aeb64c8
Compare
Yes, I added that. Might be the quickest way to resolve this instead of dealing with templating (even if that would be the proper way I guess). |
Ready for review. |
brew audit
compatible (#1908)brew audit
compatible (#1908)
Thanks! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR resolves the issues described in #1908. I want to split this into two commits:
Figuring the first one out was easy but I kinda struggle with the whitespaces. Really never thought that was the hard part... but gotemplates 🤦