Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make generated brew formulas brew audit compatible (#1908) #1911

Merged
merged 2 commits into from Nov 26, 2020

Conversation

lukasmalkmus
Copy link
Contributor

@lukasmalkmus lukasmalkmus commented Nov 22, 2020

This PR resolves the issues described in #1908. I want to split this into two commits:

  1. Add the license field (optional). If no SPDX license identifier is set, the field won't be present in the generated Formula.
  2. Get rid of the whitespaces in otherwise empty lines.

Figuring the first one out was easy but I kinda struggle with the whitespaces. Really never thought that was the hard part... but gotemplates 🤦

@vercel
Copy link

vercel bot commented Nov 22, 2020

@lukasmalkmus is attempting to deploy a commit to the Goreleaser Team on Vercel.

A member of the Team first needs to authorize it.

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 22, 2020
@codecov
Copy link

codecov bot commented Nov 22, 2020

Codecov Report

Merging #1911 (aeb64c8) into master (761c56a) will decrease coverage by 0.03%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1911      +/-   ##
==========================================
- Coverage   81.73%   81.70%   -0.04%     
==========================================
  Files          73       73              
  Lines        3866     3880      +14     
==========================================
+ Hits         3160     3170      +10     
- Misses        580      582       +2     
- Partials      126      128       +2     
Impacted Files Coverage Δ
pkg/config/config.go 93.75% <ø> (ø)
internal/pipe/brew/brew.go 77.94% <73.33%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 761c56a...aeb64c8. Read the comment docs.

Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far :)

@caarlos0
Copy link
Member

Figuring the first one out was easy but I kinda struggle with the whitespaces. Really never thought that was the hard part... but gotemplates 🤦

yeah that's always the worst, maybe we can remove them after compiling the template though 🤔

@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 25, 2020
@lukasmalkmus
Copy link
Contributor Author

yeah that's always the worst, maybe we can remove them after compiling the template though

Yes, I added that. Might be the quickest way to resolve this instead of dealing with templating (even if that would be the proper way I guess).

@lukasmalkmus
Copy link
Contributor Author

Ready for review.

@lukasmalkmus lukasmalkmus changed the title WIP: feat: make generated brew formulas brew audit compatible (#1908) feat: make generated brew formulas brew audit compatible (#1908) Nov 25, 2020
@caarlos0 caarlos0 merged commit f35534d into goreleaser:master Nov 26, 2020
@caarlos0
Copy link
Member

Thanks!

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants