Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent error if "dockerfile" isn't set #1917

Merged
merged 2 commits into from Nov 24, 2020

Conversation

dunglas
Copy link
Contributor

@dunglas dunglas commented Nov 24, 2020

Closes #1916. The problem was that the default Dockerfile name isn't taken into account if there are several lines in the matrix.

Thanks for this great project.

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 24, 2020
@vercel
Copy link

vercel bot commented Nov 24, 2020

@dunglas is attempting to deploy a commit to the Goreleaser Team on Vercel.

A member of the Team first needs to authorize it.

@caarlos0
Copy link
Member

hey, thanks for the PR :)

can you to add/fix/change tests too?

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #1917 (5db68e3) into master (5054769) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1917   +/-   ##
=======================================
  Coverage   81.73%   81.73%           
=======================================
  Files          73       73           
  Lines        3866     3866           
=======================================
  Hits         3160     3160           
  Misses        580      580           
  Partials      126      126           
Impacted Files Coverage Δ
internal/pipe/docker/docker.go 91.78% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5054769...5db68e3. Read the comment docs.

@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 24, 2020
@dunglas
Copy link
Contributor Author

dunglas commented Nov 24, 2020

@caarlos0 done!

@caarlos0 caarlos0 merged commit a6c4b7e into goreleaser:master Nov 24, 2020
@caarlos0
Copy link
Member

awesome, thanks @dunglas 🚀

@dunglas dunglas deleted the fix/1916 branch November 24, 2020 22:57
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerfile not copied when when building multiple Docker images
2 participants