Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't append empty header/footer to changelog #1918

Merged
merged 1 commit into from Nov 25, 2020

Conversation

muesli
Copy link
Contributor

@muesli muesli commented Nov 24, 2020

This will trim any superfluous newlines from the Changelog. In particular, if you don't have a ReleaseHeader set, the file will not start with two empty new-lines, but instead directly begin with ## Changelog.

@vercel
Copy link

vercel bot commented Nov 24, 2020

@muesli is attempting to deploy a commit to the Goreleaser Team on Vercel.

A member of the Team first needs to authorize it.

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 24, 2020
@caarlos0 caarlos0 changed the title Don't append empty header/footer to Changelog fix: don't append empty header/footer to changelog Nov 25, 2020
@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #1918 (10a9be2) into master (a6c4b7e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1918      +/-   ##
==========================================
- Coverage   81.73%   81.72%   -0.01%     
==========================================
  Files          73       73              
  Lines        3866     3864       -2     
==========================================
- Hits         3160     3158       -2     
  Misses        580      580              
  Partials      126      126              
Impacted Files Coverage Δ
internal/pipe/changelog/changelog.go 92.72% <100.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6c4b7e...10a9be2. Read the comment docs.

@kodiakhq kodiakhq bot merged commit 56f3493 into goreleaser:master Nov 25, 2020
@muesli muesli deleted the changelog-trim branch November 25, 2020 00:10
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants