Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure Changelog ends on a newline #1919

Merged
merged 1 commit into from Nov 25, 2020

Conversation

muesli
Copy link
Contributor

@muesli muesli commented Nov 25, 2020

This ensures the Changelog ends with a trailing newline, regardless of a footer being set.

Also added tests to verify this behavior.

@vercel
Copy link

vercel bot commented Nov 25, 2020

@muesli is attempting to deploy a commit to the Goreleaser Team on Vercel.

A member of the Team first needs to authorize it.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 25, 2020
@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #1919 (541d5f0) into master (56f3493) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1919   +/-   ##
=======================================
  Coverage   81.72%   81.73%           
=======================================
  Files          73       73           
  Lines        3864     3866    +2     
=======================================
+ Hits         3158     3160    +2     
  Misses        580      580           
  Partials      126      126           
Impacted Files Coverage Δ
internal/pipe/changelog/changelog.go 92.85% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56f3493...541d5f0. Read the comment docs.

@caarlos0 caarlos0 merged commit 761c56a into goreleaser:master Nov 25, 2020
@muesli muesli deleted the changelog-suffix branch November 25, 2020 03:29
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants