Support __completeNoDesc hidden command #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The __completeNoDesc command is used by bash to request completion without any descriptions. It must be properly supported for cobra.Command.ValidArgsFunction to work with bash completion. Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
|
@marckhouzam is attempting to deploy a commit to the Goreleaser Team on Vercel. A member of the Team first needs to authorize it. |
pull-request-size
bot
added
the
size/XS
|
/cc @caarlos0 |
Codecov Report
@@ Coverage Diff @@
## master #1922 +/- ##
=======================================
Coverage 81.69% 81.70%
=======================================
Files 73 73
Lines 3879 3880 +1
=======================================
+ Hits 3169 3170 +1
Misses 582 582
Partials 128 128
Continue to review full report at Codecov.
|
caarlos0
approved these changes
Nov 27, 2020
|
Thanks 🙏 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating spf13/cobra#1279, I noticed that turning off descriptions does not currently work for goreleaser. And that this could impact bash completion if
ValidArgsFunctionis to eventually be used.The
__completeNoDesccommand is used by bash to request completion without any descriptions. It is an alias for the__completecommand. It must be properly supported forcobra.Command.ValidArgsFunctionto work with bash completion.You can test this change by turning off descriptions for Fish completion at this line by changing
truetofalse:goreleaser/cmd/completion.go
Line 57 in c011943
Then without this PR, fish completion will be broken.
This test is representative because
bashdoes not support descriptions, so instead of using__completeit uses__completeNoDesc.