Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multi-arch docker images #1923

Merged
merged 11 commits into from Nov 28, 2020
Merged

feat: multi-arch docker images #1923

merged 11 commits into from Nov 28, 2020

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Nov 28, 2020

closes #530

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@vercel
Copy link

vercel bot commented Nov 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/goreleaser/9mi408wo9
✅ Preview: https://goreleaser-git-docker-multiarch.goreleaser.vercel.app

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 28, 2020
@caarlos0
Copy link
Member Author

I heard @gianarb will be happy to see this...

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@pull-request-size pull-request-size bot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 28, 2020
@vercel vercel bot temporarily deployed to Preview November 28, 2020 03:48 Inactive
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 28, 2020
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview November 28, 2020 03:50 Inactive
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview November 28, 2020 04:00 Inactive
@codecov
Copy link

codecov bot commented Nov 28, 2020

Codecov Report

Merging #1923 (1c46891) into master (d2f4cb7) will increase coverage by 0.15%.
The diff coverage is 95.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1923      +/-   ##
==========================================
+ Coverage   81.70%   81.85%   +0.15%     
==========================================
  Files          73       74       +1     
  Lines        3880     3925      +45     
==========================================
+ Hits         3170     3213      +43     
- Misses        582      583       +1     
- Partials      128      129       +1     
Impacted Files Coverage Δ
internal/pipe/docker/docker.go 91.78% <ø> (ø)
internal/pipe/publish/publish.go 75.00% <ø> (ø)
pkg/config/config.go 93.75% <ø> (ø)
internal/pipe/docker/manifest.go 95.55% <95.55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2f4cb7...2a24fea. Read the comment docs.

@caarlos0 caarlos0 marked this pull request as ready for review November 28, 2020 04:14
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview November 28, 2020 04:42 Inactive
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview November 28, 2020 17:37 Inactive
@caarlos0 caarlos0 merged commit e337fc9 into master Nov 28, 2020
@caarlos0 caarlos0 deleted the docker-multiarch branch November 28, 2020 19:26
@ryancurrah
Copy link
Contributor

I do not see any annotations being created in the manifest pipe after creating the manifest:

docker manifest annotate 45.55.81.106:5000/coolapp:v1 45.55.81.106:5000/coolapp-arm-linux --arch arm.

@caarlos0
Copy link
Member Author

it creates with docker manifest create and already amends all given images in a single command...

@ryancurrah
Copy link
Contributor

ryancurrah commented Nov 30, 2020

Ah cool! I read the Docker manifest docs this morning after getting notified about the recent goreleaser release and digging into this new feature. It was not clear if the annotations had to be manually set. I did look around for clearer docs but not to much info about manifests atm.

@oldthreefeng
Copy link

youre doing great job~

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multi-platform docker images
3 participants