New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support mTLS with client certificate when configured. #3302
Conversation
scr-oath
commented
Aug 10, 2022
- Support artifactory servers that use mTLS to authorize
- Add configuration and re-run the schema generation
- Add a test case that uploads with a test certificate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, can you also update the docs related to this?
from the top of my head:
- artifactory.md
- upload.md
Thanks!
Great, I added information to both of those, and also added a 💡Perhaps a task entry could be written to help with that too? But I'd love it if that could be a follow up as I'm not terribly familiar with task. |
No need to commit those, I iterate locally with Docker... there is a task for it already as well: https://github.com/goreleaser/goreleaser/blob/main/Taskfile.yml#L103 |
I just tried it - nice that it exists, but it's so very slow on M1 mac. WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested I'll just remove the files and/or rejigger to include info on using docs:serve task target - for a seldom task, being a little slow isn't the end of the world. EDITman, each change takes roughly 2m to render… I really think that the local solution is useful - this is NOT the same spirt of iteration that I was hoping for (and experienced) when using native python. I added documentation for any fellow M1 or M2 Mac owners out there for how to build the docker image - I don't notice any difference of that vs the local python like I did for the default intel docker image. |
Codecov Report
@@ Coverage Diff @@
## main #3302 +/- ##
==========================================
- Coverage 84.27% 84.15% -0.13%
==========================================
Files 116 116
Lines 9316 9332 +16
==========================================
+ Hits 7851 7853 +2
- Misses 1184 1194 +10
- Partials 281 285 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hmm, I always use it on linux/amd64 hopefully this helps squidfunk/mkdocs-material#4240 |
Fixing schema change from goreleaser#3302
Fixing schema change from goreleaser#3302 Signed-off-by: Sheridan C Rawlins <scr@yahooinc.com>
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |