feat: delay github tag creation #3330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
pull-request-size
bot
added
the
size/S
Codecov Report
@@ Coverage Diff @@
## main #3330 +/- ##
==========================================
- Coverage 84.11% 84.10% -0.01%
==========================================
Files 115 115
Lines 9134 9135 +1
==========================================
Hits 7683 7683
- Misses 1179 1180 +1
Partials 272 272
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
ok, I just tested this again (100 times) and it works. |
caarlos0
added a commit
that referenced
this pull request
Aug 23, 2022
We should not imply the target_commitish, as some users might want to have the code in one repo and the releases in another (e.g. private code, public releases), so the commit might not be there. We should instead allow the user to set the `target_commitish` (or not), and pass it down to the github api. refs 95bba02 refs #3044 refs #3330 Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3044
What happens is that, if the tag is created only locally, it'll create the tag in the remote upon creating the release. The tag still needs to be created locally though!
@bep let me know if that works for you.