Changelog in GitHub release no longer has commit links

[yogeshlonkar]

What happened?

After version v1.11.0 changelog in GitHub release no longer has commit links. Till version v1.10.3 commit hash were 40 in length in changelog which GitHub automatically links to commits, since latest versions commit has are 6 in length which GitHub doesn't automatically link to a commit.

How can we reproduce this?

Run goreleaser release --rm-dist on GitHub repository with new tag

goreleaser version

goreleaser version 1.11.1
commit: c81221016704e3f2dff72b60903f7f5f72c6f640
built at: 2022-08-29T13:25:05Z
built by: goreleaser
goos: linux
goarch: amd64
module version: v1.11.1, checksum: h1:RQsTQSmBqvmpcBCbQ4gSja1g32Z4xWokyOmq/Y0uEDY=

https://goreleaser.com

GoReleaser Check

• goreleaser check shows no errors

Search

• I did search for other open and closed issues before opening this.

Code of Conduct

• I agree to follow this project's Code of Conduct

Additional context

Screenshot releases done through latest version

Old release note content

[caarlos0]

hmm, weird, for goreleaser release itself it works: https://github.com/goreleaser/goreleaser/releases/tag/v1.11.0

although in goreleaser's case it got the first 7 instead of the first 6

this works by measuring the short commit here:

goreleaser/internal/client/github.go

Line 67 in c812210

func commitAbbrevLen(ctx *context.Context) int {

is your repo public? if so, I can investigate more...

[caarlos0]

I guess for now we can guard that behind an option, as it is only really useful when cross-releasing (e.g. code in repo a, release in repo b), in which case the longer commit hashes just make it noisier...

[yogeshlonkar]

@caarlos0 no the repository is private. In case of goreleaser I think the actual release notes contains 40 character commit hash which GitHub converts to link with 7 characters. I also realise in my repo release notes contain both 6 and 7 character commit hashes, you can see first 2 screenshots

[caarlos0]

@caarlos0 no the repository is private. In case of goreleaser I think the actual release notes contains 40 character commit hash which GitHub converts to link with 7 characters. I also realise in my repo release notes contain both 6 and 7 character commit hashes, you can see first 2 screenshots

goreleaser has the first 7, I checked...

anyway, I'll guard that behind an option

[caarlos0]

check #3349

[yogeshlonkar]

This should fix it, I'll check with in next version

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.