fix: build --single-target when using specific targets #3381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using specific targets in the config, single target becomes ineffective. This should fix it. This also removes other build options like gomips, goarm, goamd64, etc, as go will infer them from the current OS. In theory we should one day support all the GO* flags go build supports.
pull-request-size
bot
added
the
size/M
Codecov Report
@@ Coverage Diff @@
## main #3381 +/- ##
=======================================
Coverage 83.85% 83.86%
=======================================
Files 115 115
Lines 9212 9216 +4
=======================================
+ Hits 7725 7729 +4
Misses 1210 1210
Partials 277 277
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
For reference (as a backlink, since GH doesn't generate those for discussions, and for any future readers like me), this bug was noted in #3371 (reply in thread) |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using specific targets in the config, single target becomes ineffective. This should fix it. This also removes other build options like gomips, goarm, goamd64, etc, as go will infer them from the current OS. In theory we should one day support all the GO* flags go build supports.