Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MarkdownV2 for Telegram announcer #3435

Merged
merged 2 commits into from Oct 5, 2022
Merged

feat: MarkdownV2 for Telegram announcer #3435

merged 2 commits into from Oct 5, 2022

Conversation

stnokott
Copy link
Contributor

@stnokott stnokott commented Oct 4, 2022

Set MarkdownV2 as parse mode for Telegram announcer.

This allows for additional formatting in the announcement, such as code or italic sections. For details, see the official Telegram Bot API.

If someone has the time (not added in this PR), I think it would be great to add a field to the Telegram config for the parse mode. This would allow setting a different parse mode than MarkdownV2, such as HTML.

This fixes #3431.

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 4, 2022
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #3435 (c62f148) into main (4a51099) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head c62f148 differs from pull request most recent head d5bf96b. Consider uploading reports for the commit d5bf96b to get more accurate results

@@            Coverage Diff             @@
##             main    #3435      +/-   ##
==========================================
- Coverage   83.89%   83.88%   -0.01%     
==========================================
  Files         115      115              
  Lines        9235     9236       +1     
==========================================
  Hits         7748     7748              
- Misses       1210     1211       +1     
  Partials      277      277              
Impacted Files Coverage Δ
internal/pipe/telegram/telegram.go 55.17% <0.00%> (-1.98%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 added the enhancement New feature or request label Oct 5, 2022
@caarlos0 caarlos0 merged commit 81de8ad into goreleaser:main Oct 5, 2022
@github-actions github-actions bot added this to the v1.12.0 milestone Oct 5, 2022
@stnokott stnokott deleted the announce_telegram_markdown branch October 6, 2022 16:18
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set parse mode for Telegram announcer
2 participants