New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: nfpm for ios #3436
feat: nfpm for ios #3436
Conversation
Jailbroken iOS can install deb packages, and it seems the only change needed is to set the OS to `ios` instead of `linux`. Closes #3410
Codecov Report
@@ Coverage Diff @@
## main #3436 +/- ##
==========================================
+ Coverage 84.12% 84.13% +0.01%
==========================================
Files 114 114
Lines 9220 9226 +6
==========================================
+ Hits 7756 7762 +6
Misses 1188 1188
Partials 276 276
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@caarlos0 does this also need to be added to nFPM? |
Nope, it's already there Unless there are other specific differences between a Linux and iOS dev file, that's it 🤔 |
cc/ @CRKatri @Arsen6331 just double checking we good? |
Looks good to me |
Sorry if I'm blind, but where is the |
its the can we support only the latest? adding support for both would a bit messier |
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
LGTM 👍 |
so, is the iphoneos-arm64 only enough? |
I suppose. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Jailbroken iOS can install deb packages, and it seems the only change needed is to set the OS to
ios
instead oflinux
.Closes #3410
cc/ @blacktop