Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log duration of padlog steps #3439

Merged
merged 1 commit into from Oct 5, 2022
Merged

fix: log duration of padlog steps #3439

merged 1 commit into from Oct 5, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Oct 5, 2022

Sub-steps of the publish steps do not have the took: log, this will fix it.

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Oct 5, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 5, 2022
@caarlos0 caarlos0 added the bug Something isn't working label Oct 5, 2022
@vercel vercel bot temporarily deployed to Preview October 5, 2022 02:16 Inactive
@caarlos0 caarlos0 marked this pull request as ready for review October 5, 2022 02:16
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #3439 (223be2b) into main (4a51099) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3439      +/-   ##
==========================================
+ Coverage   83.89%   83.90%   +0.01%     
==========================================
  Files         115      115              
  Lines        9235     9241       +6     
==========================================
+ Hits         7748     7754       +6     
  Misses       1210     1210              
  Partials      277      277              
Impacted Files Coverage Δ
internal/middleware/logging/logging.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit d9928fe into main Oct 5, 2022
@caarlos0 caarlos0 deleted the duration branch October 5, 2022 12:33
@github-actions github-actions bot added this to the v1.11.0 milestone Oct 5, 2022
@caarlos0 caarlos0 modified the milestones: v1.11.0, v1.12.0 Oct 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant