Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

region is not templated correctly in blobs: region: #3460

Closed
3 tasks done
gerhard opened this issue Oct 13, 2022 · 7 comments · Fixed by #3461
Closed
3 tasks done

region is not templated correctly in blobs: region: #3460

gerhard opened this issue Oct 13, 2022 · 7 comments · Fixed by #3461
Assignees
Labels
enhancement New feature or request

Comments

@gerhard
Copy link

gerhard commented Oct 13, 2022

What happened?

Given the following .goreleaser.yml excerpt:

blobs:
  - provider: s3
    region: "{{ .Env.AWS_REGION }}"
    bucket: "{{ .Env.AWS_BUCKET }}"

I was expecting region to be templated. It wasn't: https://github.com/gerhard/dagger/actions/runs/3243965037/jobs/5319453856#step:10:612

How can we reproduce this?

I was running this in a GitHub Action. Here is the config: https://github.com/gerhard/dagger/blob/add-workflow-for-0.3-pre-releases/.github/workflows/release-v0.3.x.yml

This fixed it: gerhard/dagger@592cab4

If I can try the revert with a pre-release of GoReleaser, I'm up for it.

goreleaser version

https://github.com/goreleaser/goreleaser/releases/download/v1.11.5/goreleaser_Linux_x86_64.tar.gz

https://github.com/gerhard/dagger/actions/runs/3243965037/jobs/5319453856#step:10:16

GoReleaser Check

  • goreleaser check shows no errors

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

No response

@gerhard gerhard added bug Something isn't working triage Issue pending triage by one of the maintainers labels Oct 13, 2022
@caarlos0
Copy link
Member

docs don't say it is templateable, so this is more of a feature request (a valid one, though :) )

@caarlos0 caarlos0 added enhancement New feature or request and removed bug Something isn't working triage Issue pending triage by one of the maintainers labels Oct 13, 2022
@gerhard
Copy link
Author

gerhard commented Oct 13, 2022

Good point!

I was assuming (wrongly) that all values in .goreleaser.yml are templateable.

Thank you for the quick response!

@caarlos0
Copy link
Member

I was assuming (wrongly) that all values in .goreleaser.yml are templateable.

they are not, although we should definitely do a better job at specifying which ones are.

anyway, pr #3461 should fix this particular case :)

@caarlos0
Copy link
Member

oh, and thanks for reporting!

@caarlos0
Copy link
Member

fixed in #3461

caarlos0 added a commit that referenced this issue Oct 14, 2022
closes #3460

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@gerhard
Copy link
Author

gerhard commented Oct 14, 2022

This is amazing, thank you very much! 👏

Looking forward to using this when v1.12.0 ships.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants